# |
Dec 7th 2017, 14:37 |
JD-Robbs_ |
Much nicer |
# |
Dec 7th 2017, 14:37 |
JD-Robbs_ |
hmic, yeah thanks! I've fixed that up with try/catch flow now. |
# |
Dec 7th 2017, 14:28 |
neon1024 |
This was a great talk , https://www.youtube.com/watch?v=Fta49J9_rF4 |
# |
Dec 7th 2017, 14:28 |
birdy247 |
which is why I often seek your opinion :slightly_smiling_face: |
# |
Dec 7th 2017, 14:28 |
birdy247 |
I know you have |
# |
Dec 7th 2017, 14:28 |
neon1024 |
Plus conferences and user groups, the stuff I know is because the PHP Community are awesome and we all share our knowledge |
# |
Dec 7th 2017, 14:26 |
neon1024 |
Well wisdom is a bit strong, but I have been at this programming thing for a while |
# |
Dec 7th 2017, 14:25 |
neon1024 |
Bah, I can’t find the talk on youtube now, but it was a good one |
# |
Dec 7th 2017, 14:23 |
birdy247 |
@neon1024 you are a little devil of wisdom |
# |
Dec 7th 2017, 14:21 |
neon1024 |
Hah, reminds me of that keynote at PHPUK which had a slide to remind us that we put a man on the moon without Composer, Git, Gulp and all that crap |
# |
Dec 7th 2017, 14:20 |
neon1024 |
When often, “It works” is the first milestone |
# |
Dec 7th 2017, 14:20 |
neon1024 |
Had some good points about being overly attached to your code and worrying about it |
# |
Dec 7th 2017, 14:19 |
neon1024 |
Perhaps it was a PHP UK talk |
# |
Dec 7th 2017, 14:19 |
neon1024 |
Hm, his talk about legacy code isn’t on there |
# |
Dec 7th 2017, 14:18 |
neon1024 |
Perhaps my haircut has allowed my brain to reach optimal operating temparature |
# |
Dec 7th 2017, 14:18 |
neon1024 |
Maple and Pecan crunch with Honey Cheerios actually. I was between boxes |
# |
Dec 7th 2017, 14:17 |
birdy247 |
Someone had their cornflakes for breakfast today :slightly_smiling_face: |
# |
Dec 7th 2017, 14:17 |
birdy247 |
:+1: |
# |
Dec 7th 2017, 14:17 |
neon1024 |
Read Marco’s blog ;) https://ocramius.github.io/ |
# |
Dec 7th 2017, 14:15 |
neon1024 |
Which could make testing it easier |
# |
Dec 7th 2017, 14:15 |
neon1024 |
Perhaps the code needs refactoring |
# |
Dec 7th 2017, 14:15 |
neon1024 |
If your entity method is “quite involved” I would wonder if that’s a code smell |
# |
Dec 7th 2017, 14:14 |
neon1024 |
If it increases your coverage by 0.01% so what! |
# |
Dec 7th 2017, 14:14 |
neon1024 |
If you want to write BirdyEntityTest.php you go for it! |
# |
Dec 7th 2017, 14:14 |
neon1024 |
Not about where to put a test? |
# |
Dec 7th 2017, 14:14 |
birdy247 |
But point taken |
# |
Dec 7th 2017, 14:14 |
birdy247 |
I was asking a refactor question |
# |
Dec 7th 2017, 14:13 |
birdy247 |
It does exist :slightly_smiling_face: |
# |
Dec 7th 2017, 14:13 |
neon1024 |
You cannot refactor code which doesn’t exist |
# |
Dec 7th 2017, 14:13 |
neon1024 |
If it works, super, if you can refactor it to make it less crap, great! |
# |
Dec 7th 2017, 14:12 |
neon1024 |
So just write what you want to write and crack on |
# |
Dec 7th 2017, 14:12 |
neon1024 |
You can try all you want to get stuff right, but in the end it’ll be garbage in a week anyway |
# |
Dec 7th 2017, 14:12 |
neon1024 |
Which is why pre-optimisation is the devils work |
# |
Dec 7th 2017, 14:12 |
neon1024 |
Procrastinating about best practise delays development |
# |
Dec 7th 2017, 14:12 |
neon1024 |
Getting stuff working moves your project on |
# |
Dec 7th 2017, 14:12 |
neon1024 |
As soon as your save your code it’s legacy |
# |
Dec 7th 2017, 14:11 |
neon1024 |
Or if someone tells you there is, next week it’ll be legacy and the next thing will come along |
# |
Dec 7th 2017, 14:11 |
neon1024 |
Like most things in life there isn’t a best way |
# |
Dec 7th 2017, 14:11 |
neon1024 |
You’re pre-optimising |
# |
Dec 7th 2017, 14:11 |
neon1024 |
I disagree |
# |
Dec 7th 2017, 14:10 |
birdy247 |
Short term loss long term gain, would rather get things right to save time further down the line |