# |
Jun 27th 2017, 07:28 |
savant |
it was an open issue *foreveR* |
# |
Jun 27th 2017, 07:28 |
savant |
this one was pretty easy: https://github.com/cakephp/cakephp/pull/8488 |
# |
Jun 27th 2017, 07:28 |
savant |
(active for 3.x dev, tons were still doing 2.x work) |
# |
Jun 27th 2017, 07:28 |
savant |
like half the active core team lmao |
# |
Jun 27th 2017, 07:28 |
brettl |
that is always fun a multi merge and then issues |
# |
Jun 27th 2017, 07:28 |
savant |
also I wasnt even the only one working on it |
# |
Jun 27th 2017, 07:27 |
savant |
took like 60 commits to get it right |
# |
Jun 27th 2017, 07:27 |
savant |
https://github.com/cakephp/cakephp/pull/4861 |
# |
Jun 27th 2017, 07:27 |
savant |
this one was my favorite |
# |
Jun 27th 2017, 07:26 |
brettl |
whats the fun of being a developer if you dont break the build at least once |
# |
Jun 27th 2017, 07:26 |
savant |
:) |
# |
Jun 27th 2017, 07:26 |
savant |
and then fixed the test |
# |
Jun 27th 2017, 07:26 |
savant |
and broke the build with my test |
# |
Jun 27th 2017, 07:26 |
savant |
then added a test |
# |
Jun 27th 2017, 07:25 |
savant |
then got it merged |
# |
Jun 27th 2017, 07:25 |
savant |
i fucked up the first one |
# |
Jun 27th 2017, 07:25 |
savant |
my first set of pull requests: https://cl.ly/2w1s3b151m2Y |
# |
Jun 27th 2017, 07:25 |
brettl |
lol |
# |
Jun 27th 2017, 07:25 |
savant |
lmao no |
# |
Jun 27th 2017, 07:25 |
brettl |
and yet you guys are so good at it @savant |
# |
Jun 27th 2017, 07:24 |
savant |
writing good frameworks is hard :( |
# |
Jun 27th 2017, 07:23 |
savant |
because it blows the stack |
# |
Jun 27th 2017, 07:23 |
savant |
throwing exceptions isnt very user friendly |
# |
Jun 27th 2017, 07:23 |
savant |
well we also take an `_ids` key |
# |
Jun 27th 2017, 07:23 |
sebollson |
will fork the repo |
# |
Jun 27th 2017, 07:23 |
sebollson |
okay |
# |
Jun 27th 2017, 07:23 |
savant |
and show examples for one piece of data or multiple |
# |
Jun 27th 2017, 07:23 |
sebollson |
:) |
# |
Jun 27th 2017, 07:23 |
sebollson |
then why not throw marshalling exception or something |
# |
Jun 27th 2017, 07:23 |
savant |
yep just write that |
# |
Jun 27th 2017, 07:22 |
sebollson |
array of arrays |
# |
Jun 27th 2017, 07:22 |
sebollson |
hasMany requires explicitly array |
# |
Jun 27th 2017, 07:22 |
sebollson |
IF |
# |
Jun 27th 2017, 07:22 |
sebollson |
the other way around |
# |
Jun 27th 2017, 07:22 |
sebollson |
or |
# |
Jun 27th 2017, 07:21 |
slackebot |
Action: savant goes to eat ice cream |
# |
Jun 27th 2017, 07:21 |
savant |
I’m not mad :slightly_smiling_face: |
# |
Jun 27th 2017, 07:21 |
sebollson |
:) |
# |
Jun 27th 2017, 07:21 |
sebollson |
hey dont be mad |
# |
Jun 27th 2017, 07:21 |
savant |
great! much appreciated :slightly_smiling_face: |
# |
Jun 27th 2017, 07:21 |
sebollson |
i will do that |